hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Lowe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-6418) MRApp should not shutdown LogManager during shutdown
Date Mon, 29 Jun 2015 20:31:04 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-6418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14606332#comment-14606332
] 

Jason Lowe commented on MAPREDUCE-6418:
---------------------------------------

Nit: The comment wording could be improved quite a bit.  How about "Avoid closing the logging
system during unit tests, otherwise subsequent MRApp instances in the same test will fail
to log anything."?

Nit: Could you place the comments inside the function body?  Normally comments outside the
function are for documenting why the interface exists, etc.  This is more of an implementation
detail for this particular override.

> MRApp should not shutdown LogManager during shutdown
> ----------------------------------------------------
>
>                 Key: MAPREDUCE-6418
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-6418
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>            Reporter: Chang Li
>            Assignee: Chang Li
>         Attachments: MAPREDUCE-6418.1.patch, MAPREDUCE-6418.2.patch
>
>
> Tests in TestRecovery.java lost their logs after recovery due to the change of MAPREDUCE-5694.
MRApp should overwrite those changes to allow log after am recover to be shown.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message