hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brahma Reddy Battula (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-6395) Improve the commit failure messages in MRAppMaster recovery
Date Thu, 18 Jun 2015 08:49:01 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-6395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14591499#comment-14591499
] 

Brahma Reddy Battula commented on MAPREDUCE-6395:
-------------------------------------------------

Attached the patch to address the checkstyle issues..

> Improve the commit failure messages in MRAppMaster recovery
> -----------------------------------------------------------
>
>                 Key: MAPREDUCE-6395
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-6395
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: applicationmaster
>    Affects Versions: 2.7.0
>            Reporter: Gera Shegalov
>            Assignee: Brahma Reddy Battula
>              Labels: noob
>         Attachments: MAPREDUCE-6395-002.patch, MAPREDUCE-6395-003.patch, MAPREDUCE-6395.patch
>
>
> There are typos, and pluralis majestatis (royal we) or user-including "we" messages that
are confusing to the users:
> {code}
>         if (commitSuccess) {
>           shutDownMessage = "We crashed after successfully committing. Recovering.";
>           forcedState = JobStateInternal.SUCCEEDED;
>         } else if (commitFailure) {
>           shutDownMessage = "We crashed after a commit failure.";
>           forcedState = JobStateInternal.FAILED;
>         } else {
>           //The commit is still pending, commit error
>           shutDownMessage = "We crashed durring a commit";
>           forcedState = JobStateInternal.ERROR;
>         }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message