hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Lowe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-6376) Add avro binary support for jhist files
Date Tue, 30 Jun 2015 16:29:05 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-6376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14608615#comment-14608615
] 

Jason Lowe commented on MAPREDUCE-6376:
---------------------------------------

Couple of issues with the new log warning added to JobHistoryEventHandler:
- JHAdminConfig.DEFAULT_MR_HS_JHIST_FORMAT is not a property but rather a value, so the message
is misleading at best.  Not sure we need to bother mentioning the default could be wrong,
it will just confuse users.
- Nit: Rather than assume DEFAULT_MR_HS_JHIST_FORMAT is 'json', it would be better to reuse
the value, e.g.: "Falling back to default value: " + JHAdminConfig.DEFAULT_MR_HS_JHIST_FORMAT

Another approach we can take is to take the property value, upper case it, and try to call
WriteMode.valueof on it.  If we get IllegalArgumentException out of it then we can warn about
the fallback to the default value and try again (and let it blow up if it fails, since the
default value should not fail).  This has the advantage of not being a conversion we manually
need to keep in sync with the enum.  This isn't a change that has to be made for this JIRA
rather just a suggestion.


> Add avro binary support for jhist files
> ---------------------------------------
>
>                 Key: MAPREDUCE-6376
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-6376
>             Project: Hadoop Map/Reduce
>          Issue Type: Sub-task
>          Components: jobhistoryserver
>    Affects Versions: 2.7.0
>            Reporter: Ray Chiang
>            Assignee: Ray Chiang
>              Labels: supportability
>         Attachments: MAPREDUCE-6376.001.patch, MAPREDUCE-6376.002.patch, MAPREDUCE-6376.003.patch,
MAPREDUCE-6376.004.patch, MAPREDUCE-6376.005.patch
>
>
> When you click on a Job link in the JHS Web UI, it loads the .jhist file.  For jobs which
have a large number of tasks, the load time can break UI responsiveness.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message