Return-Path: X-Original-To: apmail-hadoop-mapreduce-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-mapreduce-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9C2D317381 for ; Thu, 14 May 2015 16:47:00 +0000 (UTC) Received: (qmail 67373 invoked by uid 500); 14 May 2015 16:47:00 -0000 Delivered-To: apmail-hadoop-mapreduce-issues-archive@hadoop.apache.org Received: (qmail 67318 invoked by uid 500); 14 May 2015 16:47:00 -0000 Mailing-List: contact mapreduce-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mapreduce-issues@hadoop.apache.org Delivered-To: mailing list mapreduce-issues@hadoop.apache.org Received: (qmail 67293 invoked by uid 99); 14 May 2015 16:47:00 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 14 May 2015 16:47:00 +0000 Date: Thu, 14 May 2015 16:47:00 +0000 (UTC) From: "Devaraj K (JIRA)" To: mapreduce-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (MAPREDUCE-5708) Duplicate String.format in YarnOutputFiles.getSpillFileForWrite MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/MAPREDUCE-5708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Devaraj K updated MAPREDUCE-5708: --------------------------------- Resolution: Fixed Fix Version/s: 2.8.0 Status: Resolved (was: Patch Available) Committed to trunk and branch-2. Thanks [~konnew88]. > Duplicate String.format in YarnOutputFiles.getSpillFileForWrite > --------------------------------------------------------------- > > Key: MAPREDUCE-5708 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-5708 > Project: Hadoop Map/Reduce > Issue Type: Bug > Reporter: Konstantin Weitz > Assignee: Konstantin Weitz > Priority: Minor > Labels: BB2015-05-TBR > Fix For: 2.8.0 > > Attachments: 0001-Removed-duplicate-String.format.patch > > Original Estimate: 10m > Remaining Estimate: 10m > > The code responsible for formatting the spill file name (namely _getSpillFileForWrite_) unnecessarily calls _String.format_ twice. This does not only affect performance, but leads to the weird requirement that task attempt ids cannot contain _%_ characters (because these would be interpreted as format specifiers in the outside _String.format_ call). > I assume this was done by mistake, as it could only be useful if task attempt ids contained _%n_. -- This message was sent by Atlassian JIRA (v6.3.4#6332)