hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-5708) Duplicate String.format in YarnOutputFiles.getSpillFileForWrite
Date Thu, 14 May 2015 17:08:00 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-5708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14544032#comment-14544032
] 

Hadoop QA commented on MAPREDUCE-5708:
--------------------------------------

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch |  14m 59s | Pre-patch trunk compilation is healthy. |
| {color:green}+1{color} | @author |   0m  0s | The patch does not contain any @author tags.
|
| {color:red}-1{color} | tests included |   0m  0s | The patch doesn't appear to include any
new or modified tests.  Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. |
| {color:green}+1{color} | javac |   7m 48s | There were no new javac warning messages. |
| {color:green}+1{color} | javadoc |   9m 46s | There were no new javadoc warning messages.
|
| {color:green}+1{color} | release audit |   0m 23s | The applied patch does not increase
the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle |   0m 33s | There were no new checkstyle issues. |
| {color:green}+1{color} | whitespace |   0m  0s | The patch has no lines that end in whitespace.
|
| {color:green}+1{color} | install |   1m 35s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse |   0m 33s | The patch built with eclipse:eclipse.
|
| {color:green}+1{color} | findbugs |   0m 59s | The patch does not introduce any new Findbugs
(version 2.0.3) warnings. |
| {color:green}+1{color} | mapreduce tests |  10m 42s | Tests passed in hadoop-mapreduce-client-app.
|
| | |  47m 28s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | http://issues.apache.org/jira/secure/attachment/12621475/0001-Removed-duplicate-String.format.patch
|
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / def9136 |
| hadoop-mapreduce-client-app test log | https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5735/artifact/patchprocess/testrun_hadoop-mapreduce-client-app.txt
|
| Test Results | https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5735/testReport/
|
| Java | 1.7.0_55 |
| uname | Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep
3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output | https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5735/console |


This message was automatically generated.

> Duplicate String.format in YarnOutputFiles.getSpillFileForWrite
> ---------------------------------------------------------------
>
>                 Key: MAPREDUCE-5708
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5708
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>            Reporter: Konstantin Weitz
>            Assignee: Konstantin Weitz
>            Priority: Minor
>             Fix For: 2.8.0
>
>         Attachments: 0001-Removed-duplicate-String.format.patch
>
>   Original Estimate: 10m
>  Remaining Estimate: 10m
>
> The code responsible for formatting the spill file name (namely _getSpillFileForWrite_)
unnecessarily calls _String.format_ twice. This does not only affect performance, but leads
to the weird requirement that task attempt ids cannot contain _%_ characters (because these
would be interpreted as format specifiers in the outside _String.format_ call).
> I assume this was done by mistake, as it could only be useful if task attempt ids contained
_%n_.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message