Return-Path: X-Original-To: apmail-hadoop-mapreduce-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-mapreduce-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A242917B12 for ; Thu, 16 Apr 2015 19:07:38 +0000 (UTC) Received: (qmail 12291 invoked by uid 500); 16 Apr 2015 19:06:59 -0000 Delivered-To: apmail-hadoop-mapreduce-issues-archive@hadoop.apache.org Received: (qmail 12228 invoked by uid 500); 16 Apr 2015 19:06:59 -0000 Mailing-List: contact mapreduce-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mapreduce-issues@hadoop.apache.org Delivered-To: mailing list mapreduce-issues@hadoop.apache.org Received: (qmail 12215 invoked by uid 99); 16 Apr 2015 19:06:59 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 16 Apr 2015 19:06:59 +0000 Date: Thu, 16 Apr 2015 19:06:59 +0000 (UTC) From: "Gera Shegalov (JIRA)" To: mapreduce-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (MAPREDUCE-6319) Get rid of the usage of parseHadoopAttemptID in HsTaskPage for consistency MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/MAPREDUCE-6319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gera Shegalov updated MAPREDUCE-6319: ------------------------------------- Status: Open (was: Patch Available) This patch is not sufficient. Check the code in HsTaskPage: {code} int sortId = attempt.getID().getId() + (attempt.getID().getTaskId().getId() * 10000); attemptsTableData.append("[\"") .append(sortId + " ").append(taid).append("\",\"") .append(ta.getState()).append("\",\"") {code} It should output only {{taid}} > Get rid of the usage of parseHadoopAttemptID in HsTaskPage for consistency > -------------------------------------------------------------------------- > > Key: MAPREDUCE-6319 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-6319 > Project: Hadoop Map/Reduce > Issue Type: Improvement > Components: webapps > Reporter: Akira AJISAKA > Assignee: Brahma Reddy Battula > Priority: Minor > Attachments: MAPREDUCE-6319.patch > > > Per [~jira.shegalov]'s comment in MAPREDUCE-6300: > parseHadoopAttemptID function in yarn.plugin.dt.js is used only by HsTaskPage for sorting MapReduce attempt id by numerical. On the other hand, others are calling parseHadoopID function for sorting various ids (including MapReduce attempt id) by string. We can get rid of parseHadoopAttemptID and replace with parseHadoopID for consistency. -- This message was sent by Atlassian JIRA (v6.3.4#6332)