Return-Path: 
 <mapreduce-issues-return-77457-apmail-hadoop-mapreduce-issues-archive=hadoop.apache.org@hadoop.apache.org>
X-Original-To: apmail-hadoop-mapreduce-issues-archive@minotaur.apache.org
Delivered-To: apmail-hadoop-mapreduce-issues-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 9443817495
	for <apmail-hadoop-mapreduce-issues-archive@minotaur.apache.org>;
 Mon, 20 Apr 2015 10:43:59 +0000 (UTC)
Received: (qmail 46723 invoked by uid 500); 20 Apr 2015 10:43:59 -0000
Delivered-To: apmail-hadoop-mapreduce-issues-archive@hadoop.apache.org
Received: (qmail 46652 invoked by uid 500); 20 Apr 2015 10:43:59 -0000
Mailing-List: contact mapreduce-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:mapreduce-issues-help@hadoop.apache.org>
List-Unsubscribe: <mailto:mapreduce-issues-unsubscribe@hadoop.apache.org>
List-Post: <mailto:mapreduce-issues@hadoop.apache.org>
List-Id: <mapreduce-issues.hadoop.apache.org>
Reply-To: mapreduce-issues@hadoop.apache.org
Delivered-To: mailing list mapreduce-issues@hadoop.apache.org
Received: (qmail 46638 invoked by uid 99); 20 Apr 2015 10:43:59 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 20 Apr 2015 10:43:59 +0000
Date: Mon, 20 Apr 2015 10:43:59 +0000 (UTC)
From: "Gelesh (JIRA)" <jira@apache.org>
To: mapreduce-issues@hadoop.apache.org
Message-ID: <JIRA.12690734.1390471117000.45832.1429526639273@Atlassian.JIRA>
In-Reply-To: <JIRA.12690734.1390471117000@Atlassian.JIRA>
References: <JIRA.12690734.1390471117000@Atlassian.JIRA>
 <JIRA.12690734.1390471117442@arcas>
Subject: [jira] [Commented] (MAPREDUCE-5733) Define and use a constant for
 property "textinputformat.record.delimiter"
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/MAPREDUCE-5733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14502626#comment-14502626 ] 

Gelesh commented on MAPREDUCE-5733:
-----------------------------------

This feature could be tested using a MR Unit, or with a get and set on Configuration object like
conf.set(TextInputFormat.DELIMITER,"</record>") 
Asset(conf.get("textInputFormat.record.delimiter","</record>")

Since its just a Static variable decleration, I dont think we need to place a test case for the same.

> Define and use a constant for property "textinputformat.record.delimiter"
> -------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-5733
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5733
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>            Reporter: Gelesh
>            Assignee: Gelesh
>            Priority: Trivial
>         Attachments: MAPREDUCE-5733.patch, MAPREDUCE-5733_2.patch
>
>   Original Estimate: 10m
>  Remaining Estimate: 10m
>
> (Configugration) conf.set("textinputformat.record.delimiter","myDelimiter") , is bound to typo error. Lets have it as a Static String in some class, to minimise such error. This would also help in IDE like eclipse suggesting the String.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)