hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gera Shegalov (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (MAPREDUCE-6305) AM/Task log page should be able to link back to the job
Date Thu, 23 Apr 2015 09:54:40 GMT

     [ https://issues.apache.org/jira/browse/MAPREDUCE-6305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Gera Shegalov updated MAPREDUCE-6305:
-------------------------------------
    Status: Open  (was: Patch Available)

Thanks for the pach [~l201514]. 

You don't need to use explicit regex. You can call JobID#forName and TaskAttemptID#forName
instead.

Also in HsLogsPage#preHead you need to implement the same logic as in Hs/Single/CountersPage#preHead
{code}
    commonPreHead(html);
    String tid = $(TASK_ID);
    String activeNav = "2";
    if(tid == null || tid.isEmpty()) {
      activeNav = "1";
    }
    set(initID(ACCORDION, "nav"), "{autoHeight:false, active:"+activeNav+"}");
{code}

Maybe you can factor it out to a single super class or better single util method to avoid
code triplication.



> AM/Task log page should be able to link back to the job
> -------------------------------------------------------
>
>                 Key: MAPREDUCE-6305
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-6305
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>            Reporter: Siqi Li
>            Assignee: Siqi Li
>         Attachments: MAPREDUCE-6305.v1.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message