hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gera Shegalov (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-6297) Task Id of the failed task in diagnostics should link to the task page
Date Fri, 10 Apr 2015 01:14:12 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-6297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14488702#comment-14488702
] 

Gera Shegalov commented on MAPREDUCE-6297:
------------------------------------------

Not directly related to your code, [~l201514]. With your change, I don't see any legit reason
for catching an {{Exception}} now in forName. To be conservative, we can keep it, but then
we could at least pretend that it does something useful and store it in some local variable
{{reason}}. So you can {{throw new IllegalArgumentException(exceptionMsg, reason)}} . I also
realize that after my suggestion regarding {{getAllTaskTypes()}} current task type error message
is never generated.

 [~qwertymaniac], do you think it's sufficient if we simply add [matcher.toString|http://docs.oracle.com/javase/7/docs/api/java/util/regex/Matcher.html#toString()]
regardless why matcher.matches returns false?

> Task Id of the failed task in diagnostics should link to the task page
> ----------------------------------------------------------------------
>
>                 Key: MAPREDUCE-6297
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-6297
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: jobhistoryserver
>    Affects Versions: 2.6.0
>            Reporter: Siqi Li
>            Assignee: Siqi Li
>            Priority: Minor
>         Attachments: 58CCA024-7455-4A87-BCFD-C88054FF841B.png, MAPREDUCE-6297.v1.patch,
MAPREDUCE-6297.v2.patch, MAPREDUCE-6297.v3.patch, MAPREDUCE-6297.v4.patch, MAPREDUCE-6297.v5.patch
>
>
> Currently we have to copy it and search in the task list.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message