hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsuyoshi Ozawa (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-6284) Add a 'task attempt state' to MapReduce Application Master REST API
Date Tue, 28 Apr 2015 07:04:06 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-6284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14516554#comment-14516554
] 

Tsuyoshi Ozawa commented on MAPREDUCE-6284:
-------------------------------------------

[~ryu_kobayashi] Checked your patch. Looks good to me overall. Please fix following minor
nits:

1. Please use HttpServletResponse.SC_METHOD_NOT_ALLOWED instead of 405.
{code}
+      resp.setStatus(405);
{code}

2. We can use Precondition.checkArgument instead of checking null directly.

{code}
+    if (ta == null) {
+      throw new IllegalArgumentException("ta cannot be null");
+    }
{code}


> Add a 'task attempt state' to MapReduce Application Master REST API
> -------------------------------------------------------------------
>
>                 Key: MAPREDUCE-6284
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-6284
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>            Reporter: Ryu Kobayashi
>            Priority: Minor
>         Attachments: MAPREDUCE-6284.1.patch, MAPREDUCE-6284.1.patch, MAPREDUCE-6284.2.patch
>
>
> It want to 'task attempt state' on the 'App state' similarly REST API.
> GET http://<proxy http address:port>/proxy/<application _id>/ws/v1/mapreduce/jobs/<job_id>/tasks/<task_id>/attempts/<attempt_id>/state
> PUT http://<proxy http address:port>/proxy/<application _id>/ws/v1/mapreduce/jobs/<job_id>/tasks/<task_id>/attempts/<attempt_id>/state




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message