hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-4844) Counters.java doesn't obey Java Memory Model
Date Wed, 01 Apr 2015 18:27:53 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-4844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14391157#comment-14391157
] 

Hadoop QA commented on MAPREDUCE-4844:
--------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12708750/MAPREDUCE-4844-002.patch
  against trunk revision 4922394.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core.

Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5364//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5364//console

This message is automatically generated.

> Counters.java doesn't obey Java Memory Model
> --------------------------------------------
>
>                 Key: MAPREDUCE-4844
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4844
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 3.0.0, 2.6.0
>            Reporter: Gera Shegalov
>            Assignee: Brahma Reddy Battula
>         Attachments: MAPREDUCE-4844-002.patch, MAPREDUCE-4844-002.patch, MAPREDUCE-4844-branch-1.patch
>
>
> Counters have a number of immutable fields that have not been declared 'final'.
> For example, the field groups is not final. It is, however, accessed in a couple of methods
that are declared 'synchronized'. While there is a happens-before relationship between these
methods calls, there is none between the Counters object initialization and these synchronized
methods.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message