Mailing-List: contact mapreduce-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: mapreduce-issues@hadoop.apache.org
Date: Sat, 21 Mar 2015 23:17:10 +0000 (UTC)
From: "Gera Shegalov (JIRA)" <jira@apache.org>
To: mapreduce-issues@hadoop.apache.org
Message-ID: <JIRA.12783831.1426918441000.57.1426979830130@Atlassian.JIRA>
In-Reply-To: <JIRA.12783831.1426918441000@Atlassian.JIRA>
References: <JIRA.12783831.1426918441000@Atlassian.JIRA>
 <JIRA.12783831.1426918441614@arcas>
Subject: [jira] [Commented] (MAPREDUCE-6286) A typo in HistoryViewer makes
 some code useless, which causes counter limits are not reset correctly.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/MAPREDUCE-6286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14373093#comment-14373093 ] 

Gera Shegalov commented on MAPREDUCE-6286:
------------------------------------------

+1, Thanks for spotting the bug, [~zxu]! 

[~qwertymaniac], do you mind committing to branch-2.7 as well? It looks like a safe change.

 
> A typo in HistoryViewer makes some code useless, which causes counter limits are not reset correctly.
> -----------------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-6286
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-6286
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: client
>    Affects Versions: 2.6.0
>            Reporter: zhihai xu
>            Assignee: zhihai xu
>             Fix For: 2.8.0
>
>         Attachments: MAPREDUCE-6286.000.patch
>
>
> A typo in HistoryViewer makes some code useless and it causes counter limits are not reset correctly.
> The typo is
> Limits.reset(conf);
> We should use jobConf instead of conf.
> With the typo, the following code becomes useless:
> {code}
>       final Path jobConfPath = new Path(jobFile.getParent(),  jobDetails[0]
>           + "_" + jobDetails[1] + "_" + jobDetails[2] + "_conf.xml");
>       final Configuration jobConf = new Configuration(conf);
>         jobConf.addResource(fs.open(jobConfPath), jobConfPath.toString());
> {code}
> The code wants to load the configuration from the Job configuration file and reset the Limits based on the new configuration loaded from the Job configuration file. But with the typo, the Limits are reset with the old configuration.
> So this typo is apparent.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)