Return-Path: X-Original-To: apmail-hadoop-mapreduce-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-mapreduce-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C68E917873 for ; Wed, 18 Mar 2015 13:36:39 +0000 (UTC) Received: (qmail 20623 invoked by uid 500); 18 Mar 2015 13:36:39 -0000 Delivered-To: apmail-hadoop-mapreduce-issues-archive@hadoop.apache.org Received: (qmail 20564 invoked by uid 500); 18 Mar 2015 13:36:39 -0000 Mailing-List: contact mapreduce-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mapreduce-issues@hadoop.apache.org Delivered-To: mailing list mapreduce-issues@hadoop.apache.org Received: (qmail 20552 invoked by uid 99); 18 Mar 2015 13:36:39 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Mar 2015 13:36:39 +0000 Date: Wed, 18 Mar 2015 13:36:39 +0000 (UTC) From: "Jason Lowe (JIRA)" To: mapreduce-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (MAPREDUCE-6275) Race condition in FileOutputCommitter v2 for user-specified task output subdirs MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/MAPREDUCE-6275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14367128#comment-14367128 ] Jason Lowe commented on MAPREDUCE-6275: --------------------------------------- bq.I did not change the semantics of the file replacement even if the existing path a directory. I am also not aware what is the background here, and tend to agree that we should have an extra check. Probably in a separate JIRA. Ah, yes, I missed this is basically existing behavior. Agree we can tackle this in a separate JIRA. bq. I don't think /tmp is hard coded here It is hardcoded as the fallback for a missing test.build.data setting. More specifically, I think it should be something like this: {code} private static final Path outDir = new Path( System.getProperty("test.build.data", System.getProperty("java.io.tmpdir")), TestFileOutputCommitter.class.getName()); {code} > Race condition in FileOutputCommitter v2 for user-specified task output subdirs > ------------------------------------------------------------------------------- > > Key: MAPREDUCE-6275 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-6275 > Project: Hadoop Map/Reduce > Issue Type: Bug > Reporter: Siqi Li > Assignee: Gera Shegalov > Priority: Critical > Attachments: MAPREDUCE-6275.002.patch, MAPREDUCE-6275.v1.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)