hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Akira AJISAKA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-6165) [JDK8] TestCombineFileInputFormat failed on JDK8
Date Wed, 25 Mar 2015 04:59:56 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-6165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14379299#comment-14379299
] 

Akira AJISAKA commented on MAPREDUCE-6165:
------------------------------------------

Thanks [~ozawa] for your comment.
bq. I think we should iterate splits to verify the values like this:
Would you tell me the detail?

{code}
for (CombineFileSplit fileSplit : splits) {
  if (splits.size() == 2) {
    ...
  } else if (...) {
    ...
  } else {
    fail()
  }
}
{code}
If we do as the above, we need extra if statement to verify that each split is on the expected
rack as follows:
{code}
for (InputSplit split : splits) {
  fileSplit = (CombineFileSplit) split;
  if (splits.size() == 2) {
    // if split is splits.get(0), verify the split is on rack X
    // if split is splits.get(1), verify the split is on rack Y
  } else if (splits.size() == 1) {
    // verify split is on rack Z
  } else {
    fail()
  }
}
{code}
or do you want to drop the test for each split is on the expected rack?

> [JDK8] TestCombineFileInputFormat failed on JDK8
> ------------------------------------------------
>
>                 Key: MAPREDUCE-6165
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-6165
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>            Reporter: Wei Yan
>            Assignee: Akira AJISAKA
>            Priority: Minor
>         Attachments: MAPREDUCE-6165-001.patch, MAPREDUCE-6165-002.patch, MAPREDUCE-6165-reproduce.patch
>
>
> The error msg:
> {noformat}
> testSplitPlacementForCompressedFiles(org.apache.hadoop.mapreduce.lib.input.TestCombineFileInputFormat)
 Time elapsed: 2.487 sec  <<< FAILURE!
> junit.framework.AssertionFailedError: expected:<2> but was:<1>
> 	at junit.framework.Assert.fail(Assert.java:57)
> 	at junit.framework.Assert.failNotEquals(Assert.java:329)
> 	at junit.framework.Assert.assertEquals(Assert.java:78)
> 	at junit.framework.Assert.assertEquals(Assert.java:234)
> 	at junit.framework.Assert.assertEquals(Assert.java:241)
> 	at junit.framework.TestCase.assertEquals(TestCase.java:409)
> 	at org.apache.hadoop.mapreduce.lib.input.TestCombineFileInputFormat.testSplitPlacementForCompressedFiles(TestCombineFileInputFormat.java:911)
> testSplitPlacement(org.apache.hadoop.mapreduce.lib.input.TestCombineFileInputFormat)
 Time elapsed: 0.985 sec  <<< FAILURE!
> junit.framework.AssertionFailedError: expected:<2> but was:<1>
> 	at junit.framework.Assert.fail(Assert.java:57)
> 	at junit.framework.Assert.failNotEquals(Assert.java:329)
> 	at junit.framework.Assert.assertEquals(Assert.java:78)
> 	at junit.framework.Assert.assertEquals(Assert.java:234)
> 	at junit.framework.Assert.assertEquals(Assert.java:241)
> 	at junit.framework.TestCase.assertEquals(TestCase.java:409)
> 	at org.apache.hadoop.mapreduce.lib.input.TestCombineFileInputFormat.testSplitPlacement(TestCombineFileInputFormat.java:368)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message