hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-5190) Unnecessary condition test in RandomSampler
Date Sun, 22 Mar 2015 14:35:12 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-5190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14374969#comment-14374969
] 

Hudson commented on MAPREDUCE-5190:
-----------------------------------

FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #131 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/131/])
MAPREDUCE-5190. Unnecessary condition test in RandomSampler. Contributed by Jingguo Yao. (harsh:
rev 1d5c796d654c8959972d15cc6742731a99380bfc)
* hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/partition/InputSampler.java
* hadoop-mapreduce-project/CHANGES.txt


> Unnecessary condition test in RandomSampler
> -------------------------------------------
>
>                 Key: MAPREDUCE-5190
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5190
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: mrv2
>    Affects Versions: 2.6.0
>            Reporter: Jingguo Yao
>            Assignee: Jingguo Yao
>            Priority: Minor
>             Fix For: 2.8.0
>
>         Attachments: MAPREDUCE-5190.patch
>
>   Original Estimate: 20m
>  Remaining Estimate: 20m
>
> In getSampe method, there is a condition test after "int ind = r.nextInt(numSamples);".
The test is "(ind != numSamples)".
> This test is unneeded since nextInt(numSamples) will not return numSamples.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message