Return-Path: X-Original-To: apmail-hadoop-mapreduce-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-mapreduce-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D227D17D95 for ; Thu, 5 Feb 2015 14:44:35 +0000 (UTC) Received: (qmail 7483 invoked by uid 500); 5 Feb 2015 14:44:35 -0000 Delivered-To: apmail-hadoop-mapreduce-issues-archive@hadoop.apache.org Received: (qmail 7428 invoked by uid 500); 5 Feb 2015 14:44:35 -0000 Mailing-List: contact mapreduce-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mapreduce-issues@hadoop.apache.org Delivered-To: mailing list mapreduce-issues@hadoop.apache.org Received: (qmail 7404 invoked by uid 99); 5 Feb 2015 14:44:35 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 05 Feb 2015 14:44:35 +0000 Date: Thu, 5 Feb 2015 14:44:35 +0000 (UTC) From: "lbkzman (JIRA)" To: mapreduce-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (MAPREDUCE-6245) Fixed split shuffling. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/MAPREDUCE-6245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lbkzman updated MAPREDUCE-6245: ------------------------------- Affects Version/s: 2.6.0 Release Note: index 72b47f2..8b89782 100644 --- src/java/org/apache/hadoop/mapreduce/lib/partition/InputSampler.java +++ src/java/org/apache/hadoop/mapreduce/lib/partition/InputSampler.java @@ -203,12 +203,8 @@ public class InputSampler extends Configured implement s Tool { r.setSeed(seed); LOG.debug("seed: " + seed); // shuffle splits - for (int i = 0; i < splits.size(); ++i) { - InputSplit tmp = splits.get(i); - int j = r.nextInt(splits.size()); - splits.set(i, splits.get(j)); - splits.set(j, tmp); - } + Collections.shuffle(splits); + // our target rate is in terms of the maximum number of sample splits, // but we accept the possibility of sampling additional splits to hit // the target sample keyset Status: Patch Available (was: Open) > Fixed split shuffling. > ---------------------- > > Key: MAPREDUCE-6245 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-6245 > Project: Hadoop Map/Reduce > Issue Type: Bug > Affects Versions: 2.6.0 > Reporter: lbkzman > -- This message was sent by Atlassian JIRA (v6.3.4#6332)