hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Varun Saxena (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-6225) Fix new findbug warnings in hadoop-mapreduce-client-core
Date Mon, 16 Feb 2015 11:23:13 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-6225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14322659#comment-14322659
] 

Varun Saxena commented on MAPREDUCE-6225:
-----------------------------------------

[~djp],

bq.  Now, I agree that copyAndConfigureFiles() is better because we don't care which one get
called first, but we need to make sure it get called - the other one (addLog4jToDistributedCache)
is under a condition so not proper.
I agree. That is why I had kept it the way it is in 2nd patch i.e. in copyAndConfigureFiles.
You see any other change required in the patch ? I think the change [~ozawa] suggested can
be made i.e use {{job.setWorkingDirectory(jtFs.getWorkingDirectory());}} instead of {{job.getWorkingDirectory()}}
because latter may make the code confusing.

> Fix new findbug warnings in hadoop-mapreduce-client-core
> --------------------------------------------------------
>
>                 Key: MAPREDUCE-6225
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-6225
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 2.7.0
>            Reporter: Jason Lowe
>            Assignee: Varun Saxena
>         Attachments: MAPREDUCE-6225.001.patch, MAPREDUCE-6225.002.patch
>
>
> Recent precommit builds in hadoop-mapreduce-client-core are flagging findbug warnings
that appear to be new with the recent findbugs upgrade.  These need to be cleaned up.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message