hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Varun Saxena (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-6223) TestJobConf#testNegativeValueForTaskVmem failures
Date Fri, 06 Feb 2015 06:01:34 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-6223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14308671#comment-14308671
] 

Varun Saxena commented on MAPREDUCE-6223:
-----------------------------------------

[~ajisakaa] / [~ozawa],
As you wish. Because currently test failures are appearing till MAPREDUCE-6223 is committed.
Ideally {{MRJobConfig.DEFAULT_MAP_MEMORY_MB}} should not be changed. I feel we should not
be taking default value from a local variable.
MAPREDUCE-6234 hence will be a redundant fix as we will have to revert its changes again.

Although it is somewhat confusing that default value in mapred-default.xml is -1 and in code
we take it as 1024. But if somebody reads the config description, which should be done, its
quite clear what is the behavior of this config.
{code}
<description>
  The amount of memory to request from the scheduler for each 		
  map task. If this is not specified or is non-positive, it is inferred from
  mapreduce.map.java.opts and mapreduce.job.heap.memory-mb.ratio.
  If java-opts are also not specified, we set it to 1024.
</description>
{code}

You can take a call whether to commit that or not. Alternatively you can review and commit
this as well.

> TestJobConf#testNegativeValueForTaskVmem failures
> -------------------------------------------------
>
>                 Key: MAPREDUCE-6223
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-6223
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 3.0.0
>            Reporter: Gera Shegalov
>            Assignee: Varun Saxena
>         Attachments: MAPREDUCE-6223.001.patch, MAPREDUCE-6223.002.patch
>
>
> {code}
> Tests run: 8, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 3.328 sec <<<
FAILURE! - in org.apache.hadoop.conf.TestJobConf
> testNegativeValueForTaskVmem(org.apache.hadoop.conf.TestJobConf)  Time elapsed: 0.089
sec  <<< FAILURE!
> java.lang.AssertionError: expected:<1024> but was:<-1>
> 	at org.junit.Assert.fail(Assert.java:88)
> 	at org.junit.Assert.failNotEquals(Assert.java:743)
> 	at org.junit.Assert.assertEquals(Assert.java:118)
> 	at org.junit.Assert.assertEquals(Assert.java:555)
> 	at org.junit.Assert.assertEquals(Assert.java:542)
> 	at org.apache.hadoop.conf.TestJobConf.testNegativeValueForTaskVmem(TestJobConf.java:111)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message