hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "sam liu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-6204) TestJobCounters should use new properties instead JobConf.MAPRED_TASK_JAVA_OPTS
Date Mon, 29 Dec 2014 02:27:13 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-6204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14259797#comment-14259797
] 

sam liu commented on MAPREDUCE-6204:
------------------------------------

For many deprecated properties, hadoop code always set its value to its new version of property.
Absolutely, this solution is clear and won't bring any misunderstanding on the conception
of 'deprecation'. 

However, for the deprecated property "mapred.child.java.opts", hadoop uses a different method:
it won't update the value of its new versions MRJobConfig.MAP_JAVA_OPTS and MRJobConfig.REDUCE_JAVA_OPTS.
Yes, finally hadoop will set a correct value on the classpath, however the program like MapReduce
could not get correct value of MRJobConfig.MAP_JAVA_OPTS and MRJobConfig.REDUCE_JAVA_OPTS:
it definately bring confusing to the users.

Furthermore, this ut will fail without this patch on ppc64 platform, but could pass on the
same env with this patch. Actually the root cause is the insuffcient completion of the deprecation
of property "mapred.child.java.opts". We could not say this patch is useless or simply pass
the buck to 'env issue': if this is an env issue, this ut should fail on the ppc64 platform
either with the deprecated property "mapred.child.java.opts" or with the new version of properties
MRJobConfig.MAP_JAVA_OPTS and MRJobConfig.REDUCE_JAVA_OPTS. 

Therefore this patch is necessary and could remedy the insuffcient completion of the deprecation
of property "mapred.child.java.opts".

> TestJobCounters should use new properties instead JobConf.MAPRED_TASK_JAVA_OPTS
> -------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-6204
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-6204
>             Project: Hadoop Map/Reduce
>          Issue Type: Test
>          Components: test
>    Affects Versions: 2.6.0
>            Reporter: sam liu
>            Assignee: sam liu
>            Priority: Minor
>         Attachments: MAPREDUCE-6204-1.patch, MAPREDUCE-6204.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message