hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-6160) Potential NullPointerException in MRClientProtocol interface implementation.
Date Tue, 02 Dec 2014 11:43:15 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-6160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14231364#comment-14231364
] 

Hudson commented on MAPREDUCE-6160:
-----------------------------------

ABORTED: Integrated in Hadoop-Hdfs-trunk #1951 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1951/])
MAPREDUCE-6160. Potential NullPointerException in MRClientProtocol interface implementation.
Contributed by Rohith (jlowe: rev 0c588904f8b68cad219d2bd8e33081d5cae656e5)
* hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/TestMRClientService.java
* hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/HistoryClientService.java
* hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/test/java/org/apache/hadoop/mapreduce/v2/hs/TestJobHistoryServer.java
* hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/client/MRClientService.java
* hadoop-mapreduce-project/CHANGES.txt


> Potential NullPointerException in MRClientProtocol interface implementation.
> ----------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-6160
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-6160
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>            Reporter: Rohith
>            Assignee: Rohith
>             Fix For: 2.7.0
>
>         Attachments: MAPREDUCE-6160.1.patch, MAPREDUCE-6160.2.patch, MAPREDUCE-6160.3.patch,
MAPREDUCE-6160.patch, MAPREDUCE-6160.patch
>
>
> In the implementation of MRClientProtocol, many methods can throw NullPointerExceptions.
Instead of NullPointerExceptions, better to throw IOException with proper message.
> In the HistoryClientService class and MRClientService class has #verifyAndGetJob() method
that return job object as null.
> {code}
> getTaskReport(GetTaskReportRequest request) throws IOException;
> getTaskAttemptReport(GetTaskAttemptReportRequest request) throws IOException;
> getCounters(GetCountersRequest request) throws IOException;
> getTaskAttemptCompletionEvents(GetTaskAttemptCompletionEventsRequest request) throws
IOException;
> getTaskReports(GetTaskReportsRequest request) throws IOException;
> getDiagnostics(GetDiagnosticsRequest request) throws IOException;
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message