hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rohith (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-6160) Potential NullPointerException in MRClientProtocol interface implementation.
Date Thu, 20 Nov 2014 17:30:34 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-6160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14219625#comment-14219625

Rohith commented on MAPREDUCE-6160:

bq. However it may be better to return null instead if that would make the interface more
I understand this way, let ClientServiceDelegate check for response null and handle it by
throwing IOException.Is it so?

> Potential NullPointerException in MRClientProtocol interface implementation.
> ----------------------------------------------------------------------------
>                 Key: MAPREDUCE-6160
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-6160
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>            Reporter: Rohith
>            Assignee: Rohith
>         Attachments: MAPREDUCE-6160.patch, MAPREDUCE-6160.patch
> In the implementation of MRClientProtocol, many methods can throw NullPointerExceptions.
Instead of NullPointerExceptions, better to throw IOException with proper message.
> In the HistoryClientService class and MRClientService class has #verifyAndGetJob() method
that return job object as null.
> {code}
> getTaskReport(GetTaskReportRequest request) throws IOException;
> getTaskAttemptReport(GetTaskAttemptReportRequest request) throws IOException;
> getCounters(GetCountersRequest request) throws IOException;
> getTaskAttemptCompletionEvents(GetTaskAttemptCompletionEventsRequest request) throws
> getTaskReports(GetTaskReportsRequest request) throws IOException;
> getDiagnostics(GetDiagnosticsRequest request) throws IOException;
> {code}

This message was sent by Atlassian JIRA

View raw message