Return-Path: X-Original-To: apmail-hadoop-mapreduce-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-mapreduce-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 85E5617C05 for ; Wed, 8 Oct 2014 21:03:34 +0000 (UTC) Received: (qmail 76070 invoked by uid 500); 8 Oct 2014 21:03:34 -0000 Delivered-To: apmail-hadoop-mapreduce-issues-archive@hadoop.apache.org Received: (qmail 75996 invoked by uid 500); 8 Oct 2014 21:03:34 -0000 Mailing-List: contact mapreduce-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mapreduce-issues@hadoop.apache.org Delivered-To: mailing list mapreduce-issues@hadoop.apache.org Received: (qmail 75984 invoked by uid 99); 8 Oct 2014 21:03:34 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 Oct 2014 21:03:34 +0000 Date: Wed, 8 Oct 2014 21:03:34 +0000 (UTC) From: "Jason Lowe (JIRA)" To: mapreduce-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (MAPREDUCE-6125) TestContainerLauncherImpl sometimes fails MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/MAPREDUCE-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Lowe updated MAPREDUCE-6125: ---------------------------------- Component/s: test Thanks for updating the patch, Mit. Comments: There should be a comment with ContainerManagementProtocolWithClose explaining why it's necessary, and ContainerManagementProtocolClient might be a better name. ContainerManagementProtocolWithClose should be an interface rather than an abstract class. Removes the need to write all those unused stubs. We can let the concrete classes provide the close method. Override annotations were removed and should be restored. Adding Public and Stable annotations to the mock class for test is not necessary or really applicable to a unit test ContainerManagementProtocolPB and ContainerManagementProtocolPBClientImpl imports were added but are unused. > TestContainerLauncherImpl sometimes fails > ----------------------------------------- > > Key: MAPREDUCE-6125 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-6125 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: test > Reporter: Mit Desai > Assignee: Mit Desai > Attachments: YARN-2633.patch, YARN-2633.patch, YARN-2633.patch > > > {noformat} > org.apache.hadoop.yarn.exceptions.YarnRuntimeException: java.lang.NoSuchMethodException: org.apache.hadoop.yarn.api.ContainerManagementProtocol$$EnhancerByMockitoWithCGLIB$$25708415.close() > at java.lang.Class.getMethod(Class.java:1665) > at org.apache.hadoop.yarn.factories.impl.pb.RpcClientFactoryPBImpl.stopClient(RpcClientFactoryPBImpl.java:90) > at org.apache.hadoop.yarn.ipc.HadoopYarnProtoRPC.stopProxy(HadoopYarnProtoRPC.java:54) > at org.apache.hadoop.yarn.client.api.impl.ContainerManagementProtocolProxy.mayBeCloseProxy(ContainerManagementProtocolProxy.java:79) > at org.apache.hadoop.mapreduce.v2.app.launcher.ContainerLauncherImpl$Container.kill(ContainerLauncherImpl.java:225) > at org.apache.hadoop.mapreduce.v2.app.launcher.ContainerLauncherImpl.shutdownAllContainers(ContainerLauncherImpl.java:320) > at org.apache.hadoop.mapreduce.v2.app.launcher.ContainerLauncherImpl.serviceStop(ContainerLauncherImpl.java:331) > at org.apache.hadoop.service.AbstractService.stop(AbstractService.java:221) > at org.apache.hadoop.mapreduce.v2.app.launcher.TestContainerLauncherImpl.testMyShutdown(TestContainerLauncherImpl.java:315) > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)