hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Lowe (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (MAPREDUCE-6125) TestContainerLauncherImpl sometimes fails
Date Wed, 08 Oct 2014 21:03:34 GMT

     [ https://issues.apache.org/jira/browse/MAPREDUCE-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Jason Lowe updated MAPREDUCE-6125:
----------------------------------
    Component/s: test

Thanks for updating the patch, Mit.  Comments:

There should be a comment with ContainerManagementProtocolWithClose explaining why it's necessary,
and ContainerManagementProtocolClient might be a better name.

ContainerManagementProtocolWithClose should be an interface rather than an abstract class.
 Removes the need to write all those unused stubs.  We can let the concrete classes provide
the close method.

Override annotations were removed and should be restored.

Adding Public and Stable annotations to the mock class for test is not necessary or really
applicable to a unit test

ContainerManagementProtocolPB and ContainerManagementProtocolPBClientImpl imports were added
but are unused.


> TestContainerLauncherImpl sometimes fails
> -----------------------------------------
>
>                 Key: MAPREDUCE-6125
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-6125
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: test
>            Reporter: Mit Desai
>            Assignee: Mit Desai
>         Attachments: YARN-2633.patch, YARN-2633.patch, YARN-2633.patch
>
>
> {noformat}
> org.apache.hadoop.yarn.exceptions.YarnRuntimeException: java.lang.NoSuchMethodException:
org.apache.hadoop.yarn.api.ContainerManagementProtocol$$EnhancerByMockitoWithCGLIB$$25708415.close()
> 	at java.lang.Class.getMethod(Class.java:1665)
> 	at org.apache.hadoop.yarn.factories.impl.pb.RpcClientFactoryPBImpl.stopClient(RpcClientFactoryPBImpl.java:90)
> 	at org.apache.hadoop.yarn.ipc.HadoopYarnProtoRPC.stopProxy(HadoopYarnProtoRPC.java:54)
> 	at org.apache.hadoop.yarn.client.api.impl.ContainerManagementProtocolProxy.mayBeCloseProxy(ContainerManagementProtocolProxy.java:79)
> 	at org.apache.hadoop.mapreduce.v2.app.launcher.ContainerLauncherImpl$Container.kill(ContainerLauncherImpl.java:225)
> 	at org.apache.hadoop.mapreduce.v2.app.launcher.ContainerLauncherImpl.shutdownAllContainers(ContainerLauncherImpl.java:320)
> 	at org.apache.hadoop.mapreduce.v2.app.launcher.ContainerLauncherImpl.serviceStop(ContainerLauncherImpl.java:331)
> 	at org.apache.hadoop.service.AbstractService.stop(AbstractService.java:221)
> 	at org.apache.hadoop.mapreduce.v2.app.launcher.TestContainerLauncherImpl.testMyShutdown(TestContainerLauncherImpl.java:315)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message