hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rahul Palamuttam (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-5747) Potential null pointer deference in HsTasksBlock#render()
Date Wed, 22 Oct 2014 01:43:34 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-5747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14179451#comment-14179451
] 

Rahul Palamuttam commented on MAPREDUCE-5747:
---------------------------------------------

Waiting for review.

Also is there need for a test on this patch?
I don't see the TestHsTasksBlock.java file in the test directory.

> Potential null pointer deference in HsTasksBlock#render()
> ---------------------------------------------------------
>
>                 Key: MAPREDUCE-5747
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5747
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Priority: Minor
>              Labels: newbie, patch
>         Attachments: MAPREDUCE-5747-1.patch
>
>
> At line 140:
> {code}
>         } else {
>           ta = new TaskAttemptInfo(successful, type, false);
> {code}
> There is no check for type against null.
> TaskAttemptInfo ctor deferences type:
> {code}
>   public TaskAttemptInfo(TaskAttempt ta, TaskType type, Boolean isRunning) {
>     final TaskAttemptReport report = ta.getReport();
>     this.type = type.toString();
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message