hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Lowe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-5542) Killing a job just as it finishes can generate an NPE in client
Date Wed, 15 Oct 2014 18:24:35 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-5542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14172724#comment-14172724
] 

Jason Lowe commented on MAPREDUCE-5542:
---------------------------------------

Thanks for updating the patch.  Looks better, but I noticed something I should have before.
 After sending the kill directive via the MR client the code then loops as long as the job
state isn't KILLED.  However if the job is finishing just as we send the kill then the job
may finish in a non-killed state.  I think the client would then loop until the full timeout
before returning.  Instead of checking for not KILLED we should be checking for a non-terminal
state instead (e.g. != KILLED, SUCCEEDED, or FAILED).  We can make an EnumSet of the terminal
job states and check if the status is not in that set.

> Killing a job just as it finishes can generate an NPE in client
> ---------------------------------------------------------------
>
>                 Key: MAPREDUCE-5542
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5542
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: client, mrv2
>    Affects Versions: 2.1.0-beta, 0.23.9
>            Reporter: Jason Lowe
>            Assignee: Rohith
>         Attachments: MAPREDUCE-5542.1.patch, MAPREDUCE-5542.2.patch, MAPREDUCE-5542.3.patch,
MAPREDUCE-5542.4.patch
>
>
> If a client tries to kill a job just as the job is finishing then the client can crash
with an NPE.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message