Mailing-List: contact mapreduce-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: mapreduce-issues@hadoop.apache.org
Date: Thu, 4 Sep 2014 06:43:52 +0000 (UTC)
From: "Sean Zhong (JIRA)" <jira@apache.org>
To: mapreduce-issues@hadoop.apache.org
Message-ID: <JIRA.12738929.1409779943000.15944.1409813032023@Atlassian.JIRA>
In-Reply-To: <JIRA.12738929.1409779943000@Atlassian.JIRA>
References: <JIRA.12738929.1409779943000@Atlassian.JIRA>
 <JIRA.12738929.1409779943332@arcas>
Subject: [jira] [Commented] (MAPREDUCE-6069) native-task: Style fixups and
 dead code removal
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/MAPREDUCE-6069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14121021#comment-14121021 ] 

Sean Zhong commented on MAPREDUCE-6069:
---------------------------------------

Todd,

I cannot express enough my thanks for this! I know cleaning this up will take huge amount of time. So, it is an essential steps towards making it acceptable by the community.

Consider this patch is huge, maybe it is more easy to break it down to several small patches, so that we can track the changes step by step. We can work on your patch to break it down to several smaller ones.

> native-task: Style fixups and dead code removal
> -----------------------------------------------
>
>                 Key: MAPREDUCE-6069
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-6069
>             Project: Hadoop Map/Reduce
>          Issue Type: Sub-task
>          Components: task
>            Reporter: Todd Lipcon
>         Attachments: mr-6069.txt
>
>
> A few more cleanup things we should address:
> - fix style issues (eg lines too long, bad indentation, commented-out code blocks, etc) both in Java and C++
> - Found a few pieces of unused code by running a coverage tool. We should remove them


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)