hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Binglin Chang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-6078) native-task: fix gtest build on macosx
Date Wed, 10 Sep 2014 09:24:29 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-6078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14128250#comment-14128250
] 

Binglin Chang commented on MAPREDUCE-6078:
------------------------------------------

Looks like cmake 2.6(which is in currently build requirement) does require this? The doc is
a little different, I guess I could verify this in a cmake2.6 env(need to get a old centos
env..) But I think to careful is good. 
http://www.cmake.org/cmake/help/cmake2.6docs.html#command:if

Evaluates the given expression. If the result is true, the commands in the THEN section are
invoked. Otherwise, the commands in the else section are invoked. The elseif and else sections
are optional. You may have multiple elseif clauses. **Note that the same expression must be
given to if, and endif.** Long expressions can be used and the order or precedence is that
the EXISTS, COMMAND, and DEFINED operators will be evaluated first. Then any EQUAL, LESS,
GREATER, STRLESS, STRGREATER, STREQUAL, MATCHES will be evaluated. Then NOT operators and
finally AND, OR operators will be evaluated. Possible expressions are:

> native-task: fix gtest build on macosx
> --------------------------------------
>
>                 Key: MAPREDUCE-6078
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-6078
>             Project: Hadoop Map/Reduce
>          Issue Type: Sub-task
>          Components: task
>            Reporter: Binglin Chang
>            Assignee: Binglin Chang
>            Priority: Trivial
>         Attachments: MAPREDUCE-6078.v1.patch
>
>
> Try compile the HEAD code in macos but failed, looks like MAPREDUCE-5977 separate gtest
compile from nttest in order to surpress compile warnings, but it forget to add addition compile
flags added to nttest is also required for  gtest build, this patch fix this. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message