Return-Path: 
 <mapreduce-issues-return-72072-apmail-hadoop-mapreduce-issues-archive=hadoop.apache.org@hadoop.apache.org>
X-Original-To: apmail-hadoop-mapreduce-issues-archive@minotaur.apache.org
Delivered-To: apmail-hadoop-mapreduce-issues-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 7C6AA11AD7
	for <apmail-hadoop-mapreduce-issues-archive@minotaur.apache.org>;
 Thu, 28 Aug 2014 03:33:59 +0000 (UTC)
Received: (qmail 92085 invoked by uid 500); 28 Aug 2014 03:33:59 -0000
Delivered-To: apmail-hadoop-mapreduce-issues-archive@hadoop.apache.org
Received: (qmail 92025 invoked by uid 500); 28 Aug 2014 03:33:59 -0000
Mailing-List: contact mapreduce-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:mapreduce-issues-help@hadoop.apache.org>
List-Unsubscribe: <mailto:mapreduce-issues-unsubscribe@hadoop.apache.org>
List-Post: <mailto:mapreduce-issues@hadoop.apache.org>
List-Id: <mapreduce-issues.hadoop.apache.org>
Reply-To: mapreduce-issues@hadoop.apache.org
Delivered-To: mailing list mapreduce-issues@hadoop.apache.org
Received: (qmail 91838 invoked by uid 99); 28 Aug 2014 03:33:59 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 28 Aug 2014 03:33:59 +0000
Date: Thu, 28 Aug 2014 03:33:59 +0000 (UTC)
From: "Manu Zhang (JIRA)" <jira@apache.org>
To: mapreduce-issues@hadoop.apache.org
Message-ID: <JIRA.12737017.1409118836039.29727.1409196839123@arcas>
In-Reply-To: <JIRA.12737017.1409118836039@arcas>
References: <JIRA.12737017.1409118836039@arcas>
Subject: [jira] [Commented] (MAPREDUCE-6055) native-task: findbugs,
 interface annotations, and other misc cleanup
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/MAPREDUCE-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14113292#comment-14113292 ] 

Manu Zhang commented on MAPREDUCE-6055:
---------------------------------------

Hi, Todd. The patch looks good generally, except for

1. The following change causes compilation error at my side (optimized away by IDE ?)
{code}
 public class DefaultSerializer implements INativeSerializer<Writable> {
 
   static class ModifiedByteArrayOutputStream extends ByteArrayOutputStream {
@@ -37,7 +39,6 @@
 
   private final ModifiedByteArrayOutputStream outBuffer = new ModifiedByteArrayOutputStream();
   private final DataOutputStream outData = new DataOutputStream(outBuffer);
-  private Writable buffered = null;
   private int bufferedLength = -1;
{code}

2. org.apache.hadoop.mapreduce.nativetask.Platform is intended to be extended by external platforms. The public API for users are Platform, INativeComparable and INativeSerializer<T>.



> native-task: findbugs, interface annotations, and other misc cleanup
> --------------------------------------------------------------------
>
>                 Key: MAPREDUCE-6055
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-6055
>             Project: Hadoop Map/Reduce
>          Issue Type: Sub-task
>          Components: task
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>         Attachments: mapreduce-6055.txt
>
>
> A few items which we need to address before merge:
> - fix findbugs errors
> - add interface and stability annotations to all public classes
> - fix eclipse warnings where possible



--
This message was sent by Atlassian JIRA
(v6.2#6252)