Mailing-List: contact mapreduce-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: mapreduce-issues@hadoop.apache.org
Date: Fri, 22 Aug 2014 01:51:12 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: mapreduce-issues@hadoop.apache.org
Message-ID: <JIRA.12735911.1408656916996.8964.1408672272458@arcas>
In-Reply-To: <JIRA.12735911.1408656916996@arcas>
References: <JIRA.12735911.1408656916996@arcas>
Subject: [jira] [Commented] (MAPREDUCE-6044) Fully qualified intermediate
 done directory will break per-user dir creation on Windows
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/MAPREDUCE-6044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14106333#comment-14106333 ] 

Hadoop QA commented on MAPREDUCE-6044:
--------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12663531/MAPREDUCE-6044.1.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        {color:red}-1 release audit{color}.  The applied patch generated 3 release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4816//testReport/
Release audit warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4816//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4816//console

This message is automatically generated.

> Fully qualified intermediate done directory will break per-user dir creation on Windows
> ---------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-6044
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-6044
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: jobhistoryserver
>    Affects Versions: 3.0.0, 2.6.0
>         Environment: Windows
>            Reporter: Zhijie Shen
>            Assignee: Zhijie Shen
>         Attachments: MAPREDUCE-6044.1.patch
>
>
> After MAPREDUCE-6032, the string of the intermediate done dir will be a fully qualified path.
> The following code in JobHistoryUtils tries to concat this path and user name to create a per-user dir path, using File.separator as the seperator (on Windows, it is "\").
> {code}
>   public static String getHistoryIntermediateDoneDirForUser(Configuration conf) throws IOException {
>     return getConfiguredHistoryIntermediateDoneDirPrefix(conf) + File.separator
>         + UserGroupInformation.getCurrentUser().getShortUserName();
>   }
> {code}
> Therefore, an intermediate done dir for user will become "hdfs://localhost:9201/mapred/history/done_intermediate\user". With the scheme available in the path, Path class will not replace "\" with "/", and finally FS cannot handle this path correctly: it will take "done_intermediateuser" as a single directory name.


--
This message was sent by Atlassian JIRA
(v6.2#6252)