hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zhijie Shen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-5956) MapReduce AM should not use maxAttempts to determine if this is the last retry
Date Fri, 11 Jul 2014 02:10:05 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14058229#comment-14058229
] 

Zhijie Shen commented on MAPREDUCE-5956:
----------------------------------------

The patch looks good to me overall. Just a minor comment:

For TestStagingCleanup you can remove "extends TestCase", and then remove \@Test for the cases
that you want to ignore.

> MapReduce AM should not use maxAttempts to determine if this is the last retry
> ------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-5956
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5956
>             Project: Hadoop Map/Reduce
>          Issue Type: Sub-task
>          Components: applicationmaster, mrv2
>    Affects Versions: 2.4.0
>            Reporter: Vinod Kumar Vavilapalli
>            Assignee: Wangda Tan
>            Priority: Blocker
>         Attachments: MR-5956.patch
>
>
> Found this while reviewing YARN-2074. The problem is that after YARN-2074, we don't count
AM preemption towards AM failures on RM side, but MapReduce AM itself checks the attempt id
against the max-attempt count to determine if this is the last attempt.
> {code}
>     public void computeIsLastAMRetry() {
>       isLastAMRetry = appAttemptID.getAttemptId() >= maxAppAttempts;
>     }
> {code}
> This causes issues w.r.t deletion of staging directory etc..



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message