Mailing-List: contact mapreduce-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: mapreduce-issues@hadoop.apache.org
Date: Tue, 27 May 2014 16:50:02 +0000 (UTC)
From: "Kousuke Saruta (JIRA)" <jira@apache.org>
To: mapreduce-issues@hadoop.apache.org
Message-ID: <JIRA.12715380.1400574894720.23360.1401209402046@arcas>
In-Reply-To: <JIRA.12715380.1400574894720@arcas>
References: <JIRA.12715380.1400574894720@arcas>
Subject: [jira] [Updated] (MAPREDUCE-5895) FileAlreadyExistsException was
 thrown : Temporary Index File can not be cleaned up because OutputStream
 doesn't close properly
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/MAPREDUCE-5895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kousuke Saruta updated MAPREDUCE-5895:
--------------------------------------

    Attachment: MAPREDUCE-5895.patch

I understood.
In the new patch, bos is closed and two cleanup method calls are into one method call.

> FileAlreadyExistsException was thrown : Temporary Index File can not be cleaned up because OutputStream doesn't close properly
> ------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-5895
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5895
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: client
>    Affects Versions: 3.0.0
>            Reporter: Kousuke Saruta
>         Attachments: MAPREDUCE-5895.patch, MAPREDUCE-5895.patch
>
>
> In TaskLog.java, Temporary Index File is created by following code.
> {code}
> BufferedOutputStream bos =
>   new BufferedOutputStream(
>     SecureIOUtils.createForWrite(tmpIndexFile, 0644));
> DataOutputStream dos = new DataOutputStream(bos);
> {code}
> The code is surrounded by try-finally so if some Exception/ERROR is thrown between constructing bos and dos, temporary file is not cleaned up.
> I met the situation that when a thread ran, OOM was thrown after bos created and temporary file is not cleaned up. At different time, another thread executed same logic and fail because of FileAlreadyExistsException.


--
This message was sent by Atlassian JIRA
(v6.2#6252)