Return-Path: X-Original-To: apmail-hadoop-mapreduce-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-mapreduce-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id CBB6E111C6 for ; Tue, 20 May 2014 13:58:48 +0000 (UTC) Received: (qmail 7811 invoked by uid 500); 20 May 2014 13:58:48 -0000 Delivered-To: apmail-hadoop-mapreduce-issues-archive@hadoop.apache.org Received: (qmail 7759 invoked by uid 500); 20 May 2014 13:58:48 -0000 Mailing-List: contact mapreduce-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mapreduce-issues@hadoop.apache.org Delivered-To: mailing list mapreduce-issues@hadoop.apache.org Received: (qmail 7750 invoked by uid 99); 20 May 2014 13:58:48 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 20 May 2014 13:58:48 +0000 Date: Tue, 20 May 2014 13:58:48 +0000 (UTC) From: "Hudson (JIRA)" To: mapreduce-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (MAPREDUCE-5861) finishedSubMaps field in LocalContainerLauncher does not need to be volatile MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/MAPREDUCE-5861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14003296#comment-14003296 ] Hudson commented on MAPREDUCE-5861: ----------------------------------- FAILURE: Integrated in Hadoop-Hdfs-trunk #1754 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1754/]) MAPREDUCE-5861. finishedSubMaps field in LocalContainerLauncher does not need to be volatile. (Contributed by Tsuyoshi OZAWA) (junping_du: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1594795) * /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapred/LocalContainerLauncher.java > finishedSubMaps field in LocalContainerLauncher does not need to be volatile > ---------------------------------------------------------------------------- > > Key: MAPREDUCE-5861 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-5861 > Project: Hadoop Map/Reduce > Issue Type: Improvement > Reporter: Ted Yu > Assignee: Tsuyoshi OZAWA > Priority: Minor > Fix For: 2.5.0 > > Attachments: MAPREDUCE-5861.1.patch, MAPREDUCE-5861.2.patch > > > Around line 374: > {code} > if (++finishedSubMaps == numMapTasks) { > doneWithMaps = true; > } > {code} > The increment of finishedSubMaps is not atomic. > See the answer to http://stackoverflow.com/questions/9749746/what-is-the-difference-of-atomic-volatile-synchronize . > AtomicInteger can be used to achieve atomicity. -- This message was sent by Atlassian JIRA (v6.2#6252)