Return-Path: X-Original-To: apmail-hadoop-mapreduce-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-mapreduce-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D33E210606 for ; Tue, 29 Apr 2014 03:15:20 +0000 (UTC) Received: (qmail 17930 invoked by uid 500); 29 Apr 2014 03:15:19 -0000 Delivered-To: apmail-hadoop-mapreduce-issues-archive@hadoop.apache.org Received: (qmail 17781 invoked by uid 500); 29 Apr 2014 03:15:19 -0000 Mailing-List: contact mapreduce-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mapreduce-issues@hadoop.apache.org Delivered-To: mailing list mapreduce-issues@hadoop.apache.org Received: (qmail 17566 invoked by uid 99); 29 Apr 2014 03:15:17 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 29 Apr 2014 03:15:17 +0000 Date: Tue, 29 Apr 2014 03:15:17 +0000 (UTC) From: "Sandy Ryza (JIRA)" To: mapreduce-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (MAPREDUCE-5862) Line records longer than 2x split size aren't handled correctly MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/MAPREDUCE-5862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13983935#comment-13983935 ] Sandy Ryza commented on MAPREDUCE-5862: --------------------------------------- {code} + checkRecordSpanningMultipleSplits("recordSpanningMultipleSplits.txt.bz2", + 200 * 1000, + true); {code} indentation should be: {code} + checkRecordSpanningMultipleSplits("recordSpanningMultipleSplits.txt.bz2", + 200 * 1000, true); {code} I can fix these on commit. Otherwise, the updated patch looks good to me. [~jlowe], anything you see that I'm missing? > Line records longer than 2x split size aren't handled correctly > --------------------------------------------------------------- > > Key: MAPREDUCE-5862 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-5862 > Project: Hadoop Map/Reduce > Issue Type: Bug > Affects Versions: 2.3.0 > Reporter: bc Wong > Assignee: bc Wong > Priority: Critical > Attachments: 0001-Handle-records-larger-than-2x-split-size.1.patch, 0001-Handle-records-larger-than-2x-split-size.patch, 0001-Handle-records-larger-than-2x-split-size.patch, recordSpanningMultipleSplits.txt.bz2 > > > Suppose this split (100-200) is in the middle of a record (90-240): > {noformat} > 0 100 200 300 > |---- split ----|---- curr ----|---- split ----| > <------- record -------> > 90 240 > {noformat} > > Currently, the first split would read the entire record, up to offset 240, which is good. But the 2nd split has a bug in producing a phantom record of (200, 240). -- This message was sent by Atlassian JIRA (v6.2#6252)