hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-5861) LocalContainerLauncher does not atomically update volatile variable finishedSubMaps
Date Tue, 29 Apr 2014 00:40:17 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-5861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13983800#comment-13983800

Hadoop QA commented on MAPREDUCE-5861:

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4565//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4565//console

This message is automatically generated.

> LocalContainerLauncher does not atomically update volatile variable finishedSubMaps
> -----------------------------------------------------------------------------------
>                 Key: MAPREDUCE-5861
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5861
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Tsuyoshi OZAWA
>            Priority: Minor
>         Attachments: MAPREDUCE-5861.1.patch
> Around line 374:
> {code}
>           if (++finishedSubMaps == numMapTasks) {
>             doneWithMaps = true;
>           }
> {code}
> The increment of finishedSubMaps is not atomic.
> See the answer to http://stackoverflow.com/questions/9749746/what-is-the-difference-of-atomic-volatile-synchronize
> AtomicInteger can be used to achieve atomicity.

This message was sent by Atlassian JIRA

View raw message