hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Nauroth (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (MAPREDUCE-5827) TestSpeculativeExecutionWithMRApp fails
Date Tue, 15 Apr 2014 23:39:16 GMT

     [ https://issues.apache.org/jira/browse/MAPREDUCE-5827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Chris Nauroth updated MAPREDUCE-5827:
-------------------------------------

    Attachment: MAPREDUCE-5827.3.patch

Thank you for addressing the feedback, Zhijie.  I tried patch v2, and I found that I was still
getting intermittent test failures in my Windows VM.  Digging into it, the problem was that
the MR app launched in {{testSpeculateSuccessfulWithoutUpdateEvents}} wasn't fully finished
before {{testSepculateSuccessfulWithUpdateEvents}} started running a new MR app.  Then, we'd
hit the file locking problem and the second test's job would fail.  To fix this, I've added
2 more lines to your patch that add {{app.waitForState(Service.STATE.STOPPED)}} at the end
of each test.  This way, we make sure the MR app is really completely finished before trying
to reuse the test data directory.  This version passes consistently for me on Mac and Windows.

I am +1 for this version of the patch, pending Jenkins, as long as you agree with the addition
of those 2 lines of code.  Thanks for fixing this!

> TestSpeculativeExecutionWithMRApp fails
> ---------------------------------------
>
>                 Key: MAPREDUCE-5827
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5827
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>            Reporter: Zhijie Shen
>            Assignee: Zhijie Shen
>              Labels: test
>         Attachments: MAPREDUCE-5827.1.patch, MAPREDUCE-5827.2.patch, MAPREDUCE-5827.3.patch
>
>
> {code}
> junit.framework.AssertionFailedError: Couldn't speculate successfully
> 	at junit.framework.Assert.fail(Assert.java:50)
> 	at junit.framework.Assert.assertTrue(Assert.java:20)
> 	at org.apache.hadoop.mapreduce.v2.TestSpeculativeExecutionWithMRApp.testSpeculateSuccessfulWithoutUpdateEvents(TestSpeculativeExecutionWithMRApp.java:122
> {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message