hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-5812) Make task context available to OutputCommitter.isRecoverySupported()
Date Sat, 26 Apr 2014 02:46:17 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-5812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13981854#comment-13981854
] 

Hadoop QA commented on MAPREDUCE-5812:
--------------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12642057/MAPREDUCE-5812.7.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 2 new or modified
test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4559//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4559//console

This message is automatically generated.

>  Make task context available to OutputCommitter.isRecoverySupported()
> ---------------------------------------------------------------------
>
>                 Key: MAPREDUCE-5812
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5812
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mr-am
>    Affects Versions: 2.3.0
>            Reporter: Mohammad Kamrul Islam
>            Assignee: Mohammad Kamrul Islam
>         Attachments: MAPREDUCE-5812.1.patch, MAPREDUCE-5812.2.patch, MAPREDUCE-5812.3.patch,
MAPREDUCE-5812.4.patch, MAPREDUCE-5812.5.patch, MAPREDUCE-5812.6.patch, MAPREDUCE-5812.7.patch
>
>
> Background
> ==========
> The system like Hive provides its version of  OutputCommitter. The custom implementation
of isRecoverySupported() requires task context. From taskContext:getConfiguration(), hive
checks if  hive-defined specific property is set or not. Based on the property value, it returns
true or false. However, in the current OutputCommitter:isRecoverySupported(), there is no
way of getting task config. As a result, user can't  turn on/off the MRAM recovery feature.
> Proposed resolution:
> ===============
> 1. Pass Task Context into  isRecoverySupported() method.
> Pros: Easy and clean
> Cons: Possible backward compatibility issue due to aPI changes. (Is it true?)
> 2. Call outputCommitter.setupTask(taskContext) from MRAM: The new OutputCommitter will
store the context in the class level variable and use it from  isRecoverySupported() 
> Props: No API changes. No backward compatibility issue. This call can be made from MRAppMaster.getOutputCommitter()
method for old API case.
> Cons: Might not be very clean solution due to class level variable.
> Please give your comments.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message