hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Lowe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-5789) Average Reduce time is incorrect on Job Overview page
Date Wed, 12 Mar 2014 18:06:43 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-5789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13932096#comment-13932096
] 

Jason Lowe commented on MAPREDUCE-5789:
---------------------------------------

Thanks, Rushabh!  Looks good overall, just some minor nits:

- The test should use values such that the expected value is unique to the average rather
than also being valid if just one task's reduce time is returned instead.  Both tasks have
the exact same times, and it would be nice if this could catch a regression in the average
computation.
- Please format the code to 80 columns
- Extra whitespace at the end of the test

> Average Reduce time is incorrect on Job Overview page
> -----------------------------------------------------
>
>                 Key: MAPREDUCE-5789
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5789
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: jobhistoryserver, webapps
>    Affects Versions: 0.23.10, 2.3.0
>            Reporter: Rushabh S Shah
>            Assignee: Rushabh S Shah
>         Attachments: patch-MapReduce-5789.patch
>
>
> The Average Reduce time displayed on the job overview page is incorrect.
> Previously Reduce time was calculated as difference between finishTime and shuffleFinishTime.
> It should be difference of finishTime and sortFinishTime



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message