hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hussein Baghdadi (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-5748) Potential null pointer deference in ShuffleHandler#Shuffle#messageReceived()
Date Sun, 16 Mar 2014 10:32:43 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-5748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13937073#comment-13937073
] 

Hussein Baghdadi commented on MAPREDUCE-5748:
---------------------------------------------

Ok, sorry. My fault. You are right.

> Potential null pointer deference in ShuffleHandler#Shuffle#messageReceived()
> ----------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-5748
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5748
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Priority: Minor
>
> Starting around line 510:
> {code}
>       ChannelFuture lastMap = null;
>       for (String mapId : mapIds) {
> ...
>       }
>       lastMap.addListener(metrics);
>       lastMap.addListener(ChannelFutureListener.CLOSE);
> {code}
> If mapIds is empty, lastMap would remain null, leading to NPE in addListener() call.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message