Return-Path: X-Original-To: apmail-hadoop-mapreduce-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-mapreduce-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id F0727104F7 for ; Thu, 9 Jan 2014 21:07:51 +0000 (UTC) Received: (qmail 32956 invoked by uid 500); 9 Jan 2014 21:07:51 -0000 Delivered-To: apmail-hadoop-mapreduce-issues-archive@hadoop.apache.org Received: (qmail 32909 invoked by uid 500); 9 Jan 2014 21:07:51 -0000 Mailing-List: contact mapreduce-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mapreduce-issues@hadoop.apache.org Delivered-To: mailing list mapreduce-issues@hadoop.apache.org Received: (qmail 32850 invoked by uid 99); 9 Jan 2014 21:07:51 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 09 Jan 2014 21:07:51 +0000 Date: Thu, 9 Jan 2014 21:07:51 +0000 (UTC) From: "Jinghui Wang (JIRA)" To: mapreduce-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (MAPREDUCE-5714) TestMRAppComponentDependencies causes surefire to exit without saying proper goodbye MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/MAPREDUCE-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13867057#comment-13867057 ] Jinghui Wang commented on MAPREDUCE-5714: ----------------------------------------- Added patch to remove the System.exit() call. > TestMRAppComponentDependencies causes surefire to exit without saying proper goodbye > ------------------------------------------------------------------------------------ > > Key: MAPREDUCE-5714 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-5714 > Project: Hadoop Map/Reduce > Issue Type: Bug > Components: test > Affects Versions: 2.2.0 > Environment: RHEL 6.4 > Reporter: Jinghui Wang > Fix For: 2.2.0 > > Attachments: MAPREDUCE-5714.patch > > > When running test TestMRAppComponentDependencies, surefire exits with the following message: > Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.16:test (default-test) on project hadoop-mapreduce-client-app: ExecutionException; nested exception is java.util.concurrent.ExecutionException: java.lang.RuntimeException: The forked VM terminated without saying properly goodbye. VM crash or System.exit called ? > The following code is found in o.a.h.mapreduce.v2.app.MRAppMaster#shutDownJob, which the test case inherits. So, before the test testComponentStopOrder completes in TestMRAppComponentDependencies, shutDownJob finishes executing and exits the JVM, thus causing the error. Based on the comment, the System.exit(0) is there as a workaround for before HADOOP-7140. Since the patch for HADOOP-7140 is committed in branch-2, are we safe to remove the System.exit call now. > //Bring the process down by force. > //Not needed after HADOOP-7140 > LOG.info("Exiting MR AppMaster..GoodBye!"); > sysexit(); > -- This message was sent by Atlassian JIRA (v6.1.5#6160)