Return-Path: X-Original-To: apmail-hadoop-mapreduce-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-mapreduce-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2EB06100F1 for ; Wed, 2 Oct 2013 03:56:30 +0000 (UTC) Received: (qmail 56287 invoked by uid 500); 2 Oct 2013 03:56:29 -0000 Delivered-To: apmail-hadoop-mapreduce-issues-archive@hadoop.apache.org Received: (qmail 55955 invoked by uid 500); 2 Oct 2013 03:56:26 -0000 Mailing-List: contact mapreduce-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mapreduce-issues@hadoop.apache.org Delivered-To: mailing list mapreduce-issues@hadoop.apache.org Received: (qmail 55938 invoked by uid 99); 2 Oct 2013 03:56:25 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Oct 2013 03:56:25 +0000 Date: Wed, 2 Oct 2013 03:56:25 +0000 (UTC) From: "Arun C Murthy (JIRA)" To: mapreduce-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (MAPREDUCE-5530) Binary and source incompatibility in mapred.lib.CombineFileInputFormat between branch-1 and branch-2 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/MAPREDUCE-5530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arun C Murthy updated MAPREDUCE-5530: ------------------------------------- Status: Patch Available (was: Open) Thanks [~rkanter]. Submitting patch for hudson on your behalf so that we can commit this asap. > Binary and source incompatibility in mapred.lib.CombineFileInputFormat between branch-1 and branch-2 > ---------------------------------------------------------------------------------------------------- > > Key: MAPREDUCE-5530 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-5530 > Project: Hadoop Map/Reduce > Issue Type: Sub-task > Components: mrv1, mrv2 > Affects Versions: 2.1.1-beta > Reporter: Robert Kanter > Assignee: Robert Kanter > Priority: Blocker > Attachments: MAPREDUCE-5530.patch, MAPREDUCE-5530.patch, MAPREDUCE-5530.patch, MAPREDUCE-5530.patch > > > {{mapred.lib.CombineFileInputFormat}} in branch-1 has this method: > {code:java} > protected boolean isSplitable(FileSystem fs, Path file) > {code} > In branch-2, {{mapred.lib.CombineFileInputFormat}} is now a subclass of {{mapreduce.lib.input.CombineFileInputFormat}}, from which it inherits the similar method: > {code:java} > protected boolean isSplitable(JobContext context, Path file) > {code} > This means that any code that subclasses {{mapred.lib.CombineFileInputFormat}} and does not provide its own implementation of {{protected boolean isSplitable(FileSystem fs, Path file)}} will not be binary or source compatible if it tries to call {{isSplitable}} with a {{FileSystem}} argument anywhere (that is, if compiled against branch-1, it will throw a {{NoSuchMethodError}} if run against branch-2; also, it won't even compile against branch-2). -- This message was sent by Atlassian JIRA (v6.1#6144)