hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-5601) ShuffleHandler fadvises file regions as DONTNEED even when fetch fails
Date Wed, 30 Oct 2013 22:23:26 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-5601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13809703#comment-13809703
] 

Hadoop QA commented on MAPREDUCE-5601:
--------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12611008/MAPREDUCE-5601.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:red}-1 javac{color:red}.  The patch appears to cause the build to fail.

Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4159//console

This message is automatically generated.

> ShuffleHandler fadvises file regions as DONTNEED even when fetch fails
> ----------------------------------------------------------------------
>
>                 Key: MAPREDUCE-5601
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5601
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>    Affects Versions: 2.2.0
>            Reporter: Sandy Ryza
>            Assignee: Sandy Ryza
>         Attachments: MAPREDUCE-5601.patch, MAPREDUCE-5601.patch
>
>
> When a reducer initiates a fetch request, it does not know whether it will be able to
fit the fetched data in memory.  The first part of the response tells how much data will be
coming.  If space is not currently available, the reduce will abandon its request and try
again later.  When this occurs, the ShuffleHandler still fadvises the file region as DONTNEED.
 Meaning that the next time it's asked for, it will definitely be read from disk, even if
it happened to be in the page cache before the request.
> I noticed this when trying to figure out why my job was doing so much more disk IO in
MR2 than in MR1.  When I turned the fadvise stuff off, I found that disk reads went to nearly
0 on machines that had enough memory to fit map outputs into the page cache.  I then straced
the NodeManager and noticed that there were over four times as many fadvise DONTNEED calls
as map-reduce pairs.  Further logging showed the same map outputs being fetched about this
many times.
> This is a regression from MR1, which only did the fadvise DONTNEED after all the bytes
were transferred.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message