hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-5569) FloatSplitter is not generating correct splits
Date Wed, 09 Oct 2013 15:58:42 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-5569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13790545#comment-13790545
] 

Hudson commented on MAPREDUCE-5569:
-----------------------------------

SUCCESS: Integrated in Hadoop-trunk-Commit #4573 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/4573/])
MAPREDUCE-5569. FloatSplitter is not generating correct splits. Contributed by Nathan Roberts
(jlowe: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1530683)
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/db/FloatSplitter.java


> FloatSplitter is not generating correct splits
> ----------------------------------------------
>
>                 Key: MAPREDUCE-5569
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5569
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: trunk, 2.1.0-beta, 1.3.0, 0.23.9
>            Reporter: Nathan Roberts
>            Assignee: Nathan Roberts
>         Attachments: MAPREDUCE-5569-branch-1.patch, MAPREDUCE-5569-trunk.patch
>
>
> The closing split is not calculated correctly:
> {code}
>      // Catch any overage and create the closed interval for the last split.
>      if (curLower <= maxVal || splits.size() == 1) {
>        splits.add(new DataDrivenDBInputFormat.DataDrivenDBInputSplit(
> -          lowClausePrefix + Double.toString(curUpper),
> +          lowClausePrefix + Double.toString(curLower),
>            colName + " <= " + Double.toString(maxVal)));
>      }
> {code}
> For the case of min=5.0, max=7.0, 2 splits, the current code returns splits of (column1
>=5.0, column1 <6.0), (column1 >=7.0, column1 <=7.0). The second split is obviously
not correct.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message