hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-5544) JobClient#getJob loads job conf twice
Date Tue, 01 Oct 2013 19:03:24 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-5544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13783224#comment-13783224
] 

Hadoop QA commented on MAPREDUCE-5544:
--------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12606151/MAPREDUCE-5544-1.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4073//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4073//console

This message is automatically generated.

> JobClient#getJob loads job conf twice
> -------------------------------------
>
>                 Key: MAPREDUCE-5544
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5544
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>            Reporter: Sandy Ryza
>            Assignee: Sandy Ryza
>         Attachments: MAPREDUCE-5544-1.patch, MAPREDUCE-5544.patch
>
>
> Calling JobClient#getJob causes the job conf file to be loaded twice, once in the constructor
of JobClient.NetworkedJob and once in Cluster#getJob.  We should remove the former.
> MAPREDUCE-5001 was meant to fix a race that was causing problems in Hive tests, but the
problem persists because it only fixed one of the places where the job conf file is loaded.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message