Return-Path: X-Original-To: apmail-hadoop-mapreduce-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-mapreduce-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 23312F3FA for ; Sat, 24 Aug 2013 13:30:04 +0000 (UTC) Received: (qmail 49598 invoked by uid 500); 24 Aug 2013 13:30:02 -0000 Delivered-To: apmail-hadoop-mapreduce-issues-archive@hadoop.apache.org Received: (qmail 49215 invoked by uid 500); 24 Aug 2013 13:29:59 -0000 Mailing-List: contact mapreduce-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mapreduce-issues@hadoop.apache.org Delivered-To: mailing list mapreduce-issues@hadoop.apache.org Received: (qmail 48901 invoked by uid 99); 24 Aug 2013 13:29:57 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 24 Aug 2013 13:29:57 +0000 Date: Sat, 24 Aug 2013 13:29:57 +0000 (UTC) From: "Hudson (JIRA)" To: mapreduce-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (MAPREDUCE-5478) TeraInputFormat unnecessarily defines its own FileSplit subclass MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/MAPREDUCE-5478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13749385#comment-13749385 ] Hudson commented on MAPREDUCE-5478: ----------------------------------- SUCCESS: Integrated in Hadoop-Hdfs-trunk #1501 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1501/]) MAPREDUCE-5478. TeraInputFormat unnecessarily defines its own FileSplit subclass (Sandy Ryza) (sandy: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1517046) * /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/terasort/TeraInputFormat.java * /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/terasort/TeraScheduler.java > TeraInputFormat unnecessarily defines its own FileSplit subclass > ---------------------------------------------------------------- > > Key: MAPREDUCE-5478 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-5478 > Project: Hadoop Map/Reduce > Issue Type: Improvement > Components: examples > Affects Versions: 2.1.0-beta > Reporter: Sandy Ryza > Assignee: Sandy Ryza > Priority: Minor > Fix For: 2.1.1-beta > > Attachments: MAPREDUCE-5478.patch > > > TeraInputFormat defines its own TeraFileSplit subclass of FileSplit that adds a locations field, which is already included in FileSplit. > This is causing MR2 TeraSort to fail on MR1, which, for a System.arraycopy, requires splits to be of the FileSplit class. While nobody is promising that everything that runs on MR2 should run on MR1, fixing this would be easy and make it possible to compare MR2 TeraSort performance between MR1 and MR2. > We should just get rid of TeraFileSplit and use FileSplit. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira