Return-Path: X-Original-To: apmail-hadoop-mapreduce-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-mapreduce-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9B52110227 for ; Thu, 22 Aug 2013 19:17:53 +0000 (UTC) Received: (qmail 73423 invoked by uid 500); 22 Aug 2013 19:17:53 -0000 Delivered-To: apmail-hadoop-mapreduce-issues-archive@hadoop.apache.org Received: (qmail 73371 invoked by uid 500); 22 Aug 2013 19:17:52 -0000 Mailing-List: contact mapreduce-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mapreduce-issues@hadoop.apache.org Delivered-To: mailing list mapreduce-issues@hadoop.apache.org Received: (qmail 73216 invoked by uid 99); 22 Aug 2013 19:17:52 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 22 Aug 2013 19:17:52 +0000 Date: Thu, 22 Aug 2013 19:17:52 +0000 (UTC) From: "Chris Nauroth (JIRA)" To: mapreduce-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (MAPREDUCE-5470) LocalJobRunner does not work on Windows. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/MAPREDUCE-5470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Nauroth updated MAPREDUCE-5470: ------------------------------------- Hadoop Flags: Reviewed +1 for the patch. Thanks very much, Sandy! I've verified tests on Mac and Windows. I'm planning on committing this later today, pending a successful Jenkins run, which I've triggered manually here: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3954/ > LocalJobRunner does not work on Windows. > ---------------------------------------- > > Key: MAPREDUCE-5470 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-5470 > Project: Hadoop Map/Reduce > Issue Type: Bug > Affects Versions: 3.0.0, 2.1.1-beta > Reporter: Chris Nauroth > Assignee: Sandy Ryza > Attachments: MAPREDUCE-5470.patch > > > {{LocalJobRunner#getLocalTaskDir}} creates a directory that is unique to the task ID. The logic of this method concatenates the local job dir and a task-specific path, but one of the arguments is a {{Path}} with a scheme, so the final result has "file:" embedded in it. This works on Linux, but the ':' is an invalid character in a file name on Windows. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira