Return-Path: X-Original-To: apmail-hadoop-mapreduce-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-mapreduce-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id EE0AB105F0 for ; Fri, 2 Aug 2013 20:35:49 +0000 (UTC) Received: (qmail 35065 invoked by uid 500); 2 Aug 2013 20:35:49 -0000 Delivered-To: apmail-hadoop-mapreduce-issues-archive@hadoop.apache.org Received: (qmail 35027 invoked by uid 500); 2 Aug 2013 20:35:49 -0000 Mailing-List: contact mapreduce-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mapreduce-issues@hadoop.apache.org Delivered-To: mailing list mapreduce-issues@hadoop.apache.org Received: (qmail 35019 invoked by uid 99); 2 Aug 2013 20:35:49 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Aug 2013 20:35:49 +0000 Date: Fri, 2 Aug 2013 20:35:49 +0000 (UTC) From: "Siddharth Seth (JIRA)" To: mapreduce-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (MAPREDUCE-5384) Races in DelegationTokenRenewal MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/MAPREDUCE-5384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Siddharth Seth updated MAPREDUCE-5384: -------------------------------------- Status: Open (was: Patch Available) We should avoid any rpc operations (token renewal) inside of a synchronized block. Currently it looks like a cancel operation could end up synchronizing on such an operation which can take time. > Races in DelegationTokenRenewal > ------------------------------- > > Key: MAPREDUCE-5384 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-5384 > Project: Hadoop Map/Reduce > Issue Type: Bug > Affects Versions: 1.1.2, 1.2.0, 1.2.1 > Reporter: Karthik Kambatla > Assignee: Karthik Kambatla > Attachments: mr-5384-0.patch, mr-5384-1.patch > > > There are a couple of races in DelegationTokenRenewal. > One of them was addressed by MAPREDUCE-4860, which introduced a deadlock while fixing this race. Opening a new JIRA per discussion in MAPREDUCE-5364, since MAPREDUCE-4860 is already shipped in a release. > Races to fix: > # TimerTask#cancel() disallows future invocations of run(), but doesn't abort an already scheduled/started run(). > # In the context of DelegationTokenRenewal, RenewalTimerTask#cancel() only cancels that TimerTask instance. However, it has no effect on any other TimerTasks created for that token. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira