hadoop-mapreduce-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alejandro Abdelnur (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MAPREDUCE-5311) Replace SLOTS_MILLIS counters with MEM_MILLIS
Date Wed, 14 Aug 2013 18:02:49 GMT

    [ https://issues.apache.org/jira/browse/MAPREDUCE-5311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13739970#comment-13739970
] 

Alejandro Abdelnur commented on MAPREDUCE-5311:
-----------------------------------------------

[~acmurthy], I'm glad you are glad, *smile*.

Yes, we agree we need to leave SLOT_MILLIS because Hadoop 0.23 users are relying on it.

We also agreed before that we should remove 'minimum resource capability' from the protocol
and the API because it is a scheduler implementation internal thing that should not be exposed
to the users.

The current code relies on using 'minimum resource capability' configuration property which
is internal. We've also agreed on doing that until this JIRA is fixed.

The proposed solution is a tweak to the current code just using a different configuration
property, nothing else.

Adding 'minimum resource capability' back to the protocol and API to support deprecated functionality
that we all agree it should go away does not seem right.

I prefer [~jlowe] suggestion to have a new  (& deprecated) configuration property that
users upgrading from 0.23 and wanting to preserve the SLOT_MILLIS counter information can
use (and if they don't -default setting- SLOT_MILLIS is always zero).

Also, doing the constant replacement is much simple that reintroducing the protocol and API
minimum field.

Lets move forward with this.

                
> Replace SLOTS_MILLIS counters with MEM_MILLIS
> ---------------------------------------------
>
>                 Key: MAPREDUCE-5311
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5311
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: applicationmaster
>    Affects Versions: 2.0.4-alpha
>            Reporter: Alejandro Abdelnur
>            Assignee: Sandy Ryza
>            Priority: Blocker
>             Fix For: 2.1.0-beta
>
>         Attachments: MAPREDUCE-5311-1.patch, MAPREDUCE-5311.patch, MAPREDUCE-5311.patch
>
>
> Per discussion in MAPREDUCE-5310 and comments in the code we should remove all the related
logic and just leave the counter constant for backwards compatibility and deprecate the counter
constants.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message