Return-Path: 
 <mapreduce-issues-return-61959-apmail-hadoop-mapreduce-issues-archive=hadoop.apache.org@hadoop.apache.org>
X-Original-To: apmail-hadoop-mapreduce-issues-archive@minotaur.apache.org
Delivered-To: apmail-hadoop-mapreduce-issues-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id B2F72C3E9
	for <apmail-hadoop-mapreduce-issues-archive@minotaur.apache.org>;
 Tue, 18 Jun 2013 20:42:20 +0000 (UTC)
Received: (qmail 85321 invoked by uid 500); 18 Jun 2013 20:42:20 -0000
Delivered-To: apmail-hadoop-mapreduce-issues-archive@hadoop.apache.org
Received: (qmail 85274 invoked by uid 500); 18 Jun 2013 20:42:20 -0000
Mailing-List: contact mapreduce-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:mapreduce-issues-help@hadoop.apache.org>
List-Unsubscribe: <mailto:mapreduce-issues-unsubscribe@hadoop.apache.org>
List-Post: <mailto:mapreduce-issues@hadoop.apache.org>
List-Id: <mapreduce-issues.hadoop.apache.org>
Reply-To: mapreduce-issues@hadoop.apache.org
Delivered-To: mailing list mapreduce-issues@hadoop.apache.org
Received: (qmail 85265 invoked by uid 99); 18 Jun 2013 20:42:20 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Jun 2013 20:42:20 +0000
Date: Tue, 18 Jun 2013 20:42:20 +0000 (UTC)
From: "Jason Lowe (JIRA)" <jira@apache.org>
To: mapreduce-issues@hadoop.apache.org
Message-ID: <JIRA.12652104.1370903259606.134964.1371588140465@arcas>
In-Reply-To: <JIRA.12652104.1370903259606@arcas>
References: <JIRA.12652104.1370903259606@arcas>
Subject: [jira] [Updated] (MAPREDUCE-5316) job -list-attempt-ids command
 does not handle illegal task-state
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


     [ https://issues.apache.org/jira/browse/MAPREDUCE-5316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jason Lowe updated MAPREDUCE-5316:
----------------------------------

       Resolution: Fixed
    Fix Version/s: 2.3.0
                   0.23.9
     Hadoop Flags: Reviewed
           Status: Resolved  (was: Patch Available)

Thanks, Ashwin!  I committed this to trunk, branch-2, and branch-0.23.
                
> job -list-attempt-ids command does not handle illegal task-state
> ----------------------------------------------------------------
>
>                 Key: MAPREDUCE-5316
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5316
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: client
>    Affects Versions: 3.0.0, 2.0.4-alpha, 0.23.8
>            Reporter: Ashwin Shankar
>            Assignee: Ashwin Shankar
>             Fix For: 0.23.9, 2.3.0
>
>         Attachments: MAPREDUCE-5316-1-b23.txt, MAPREDUCE-5316-1.txt
>
>
> Courtesy : [~mikanboy]
> {quote}
> job -list-attempt-ids command should handle illegal argument for <task-state>
> the same way as <task-type>.  Right now only illegal <task-type> is handle by
> an exception being thrown. Illegal <task-state> on the other hand does not
> throw exception. For example is a user mistype 'completed' as 'complete', they
> may wrongly think there are no completed tasks, instead of being notified of
> the illegal <task-state> that was used.
> 1) illegal <task-type> handled.
> [philips@gwbl2003:4095 ~/svn/HadoopQEAutomation/branch-23]$
> /home/gs/gridre/yroot.theoden/share/hadoop/bin/mapred job -list-attempt-ids
> job_1345673924741_0086 map completed
> 12/08/24 15:16:31 WARN conf.Configuration: mapred.used.genericoptionsparser is
> deprecated. Instead, use mapreduce.client.genericoptionsparser.used
> Exception in thread "main" java.lang.IllegalArgumentException: No enum const
> class org.apache.hadoop.mapreduce.TaskType.map
>         at java.lang.Enum.valueOf(Enum.java:196)
>         at org.apache.hadoop.mapreduce.TaskType.valueOf(TaskType.java:27)
>         at org.apache.hadoop.mapreduce.tools.CLI.displayTasks(CLI.java:553)
>         at org.apache.hadoop.mapreduce.tools.CLI.run(CLI.java:309)
>         at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:69)
>         at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:83)
>         at org.apache.hadoop.mapred.JobClient.main(JobClient.java:1242)
> 1) illegal <task-state> not handled.
> /home/gs/gridre/yroot.theoden/share/hadoop/bin/mapred job -list-attempt-ids
> job_1345673924741_0086 MAP complete
> 12/08/24 15:15:47 WARN conf.Configuration: mapred.used.genericoptionsparser is
> deprecated. Instead, use mapreduce.client.genericoptionsparser.used
> {quote}
> Also,we could make input task-state to be case-insensitive to be consistent with
> task-type behavior(MAPREDUCE-4019).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira