Mailing-List: contact mapreduce-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: mapreduce-issues@hadoop.apache.org
Date: Thu, 6 Jun 2013 03:41:20 +0000 (UTC)
From: "Alejandro Abdelnur (JIRA)" <jira@apache.org>
To: mapreduce-issues@hadoop.apache.org
Message-ID: <JIRA.12651179.1370456586362.76068.1370490080661@arcas>
In-Reply-To: <JIRA.12651179.1370456586362@arcas>
References: <JIRA.12651179.1370456586362@arcas>
Subject: [jira] [Commented] (MAPREDUCE-5304) mapreduce.Job
 killTask/failTask/getTaskCompletionEvents methods have incompatible
 signature changes
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/MAPREDUCE-5304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13676647#comment-13676647 ] 

Alejandro Abdelnur commented on MAPREDUCE-5304:
-----------------------------------------------

bq. One addition question. Have we reached an agreement on fixing binary compatibility to MR1 of mapreduce API at the cost of binary incompatibility to 0.23?

AFAIK we are fixing binary compatibility between Hadoop 1 and Hadoop 2 for the mapred API and source compatibility between Hadoop 1 and Hadoop 2 for mapreduce API (which this JIRA  is doing a bit).

Regarding Hadoop 0.23 to Hadoop 2, as explained in MAPREDUCE-4942 we are in Catch 22 situation and we cannot fix compatibility of Hadoop 2 with Hadoop 1 and Hadoop 0.23, we have to choose either Hadoop 1 or Hadoop 0.23. Given the outcome of the discussion in MAPREDUCE-4942 (as of May 22, 2013) I was under the impression that we settled for Hadoop 1 to Hadoop 2. If you think this is not the case yet, please bring it up in the dev alias.
                
> mapreduce.Job killTask/failTask/getTaskCompletionEvents methods have incompatible signature changes
> ---------------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-5304
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5304
>             Project: Hadoop Map/Reduce
>          Issue Type: Sub-task
>    Affects Versions: 2.0.4-alpha
>            Reporter: Alejandro Abdelnur
>            Assignee: Karthik Kambatla
>            Priority: Blocker
>         Attachments: mr-5304-1.patch
>
>
> Pointed out by [~zjshen] in MAPREDUCE-4942.
> In {{o.a.h.mapreduce.Job}} class, the following changed from Hadoop 1 to Hadoop 2.
> boolean failTask(TaskAttemptID): Change in return type from void to boolean.
> boolean killTask(TaskAttemptID): Change in return type from void to boolean.
> TaskCompletionEvent[] getTaskCompletionEvents(int): Change in return type from org.apache.hadoop.mapred.TaskCompletionEvent[] to org.apache.hadoop.mapreduce.TaskCompletionEvent[].
> Using same rational as in other JIRAs, we should fix this to ensure Hadoop 1 to Hadoop 2 source compatibility (taking 0.23.x releases as a casualty as there is not right way for everybody because we screwed up :( ). Flagging it as incompatible change because of 0.23.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira