Return-Path: X-Original-To: apmail-hadoop-mapreduce-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-mapreduce-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A241110600 for ; Sat, 8 Jun 2013 08:02:36 +0000 (UTC) Received: (qmail 61784 invoked by uid 500); 8 Jun 2013 08:02:34 -0000 Delivered-To: apmail-hadoop-mapreduce-issues-archive@hadoop.apache.org Received: (qmail 61686 invoked by uid 500); 8 Jun 2013 08:02:25 -0000 Mailing-List: contact mapreduce-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mapreduce-issues@hadoop.apache.org Delivered-To: mailing list mapreduce-issues@hadoop.apache.org Received: (qmail 61666 invoked by uid 99); 8 Jun 2013 08:02:21 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 08 Jun 2013 08:02:21 +0000 Date: Sat, 8 Jun 2013 08:02:21 +0000 (UTC) From: =?utf-8?Q?R=C3=A9my_SAISSY_=28JIRA=29?= To: mapreduce-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (MAPREDUCE-5264) FileAlreadyExistsException is assumed to be thrown by FileSystem#mkdirs or FileContext#mkdir in the codebase MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/MAPREDUCE-5264?page=3Dcom.atlas= sian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D= 13678705#comment-13678705 ]=20 R=C3=A9my SAISSY commented on MAPREDUCE-5264: ---------------------------------------- It was mainly about removing catch() {} with a logging statement inside. No need to add test cases for it. =20 > FileAlreadyExistsException is assumed to be thrown by FileSystem#mkdirs o= r FileContext#mkdir in the codebase > -------------------------------------------------------------------------= ----------------------------------- > > Key: MAPREDUCE-5264 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-5264 > Project: Hadoop Map/Reduce > Issue Type: Bug > Affects Versions: 3.0.0, 2.1.0-beta > Reporter: R=C3=A9my SAISSY > Attachments: MAPREDUCE-5264.20130607.1.patch > > > According to https://issues.apache.org/jira/browse/HADOOP-9438, > FileSystem#mkdirs and FileContext#mkdir do not throw FileAlreadyExistsExc= eption if the directory already exist. > Some places in the mapreduce codebase assumes FileSystem#mkdirs or FileCo= ntext#mkdir throw FileAlreadyExistsException. > At least the following files are concerned: > - YarnChild.java > - JobHistoryEverntHandler.java > - HistoryFileManager.java > It would be good to re-review and patch this if needed. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrato= rs For more information on JIRA, see: http://www.atlassian.com/software/jira